Don't use deprecated asmjit templates #4481
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@q10 gtest also failed because of deprecated functions, now it is fixed. |
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
|
@q10 I disable another warning on MacOS CLAPACK. Since FBGEMM doesn't build on Apple Silicon (for no AVX512), I temporarily disable it. Will recheck the decision later when I can build it on M2. |
|
@q10 Let's restore the option but keep the source code changes because I don't have Intel Macbook at hand.. |
|
@cyyever It looks like the changes break the macOS CI builds. |
cyyever
force-pushed
the
deprecated2
branch
2 times, most recently
from
d60c852 to
943be88
Compare
Signed-off-by: cyy <cyyever@outlook.com>
|
@q10 More reverts |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Jul 15, 2025
Summary: X-link: facebookresearch/FBGEMM#1550 Clean up these deprecation warnings before it is possible to build newer asmjit. Pull Request resolved: pytorch#4481 Reviewed By: cthi Differential Revision: D78252575 Pulled By: q10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up these deprecation warnings before it is possible to build newer asmjit.